]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
altTab: Don't fade out thumbnails on destroy
authorJonas Dreßler <verdre@v0yd.nl>
Mon, 27 Jan 2020 22:42:28 +0000 (23:42 +0100)
committerFlorian Müllner <florian.muellner@gmail.com>
Wed, 26 Feb 2020 22:46:51 +0000 (22:46 +0000)
The thumbnails actor `this._thumbnails` has already been destroyed when
calling `_destroyThumbnails()` from the `destroy` signal handler because
it is a child actor of the AppSwitcherPopup. So stop destroying the
thumbnails separately (fading them out inside a destroy handler wouldn't
make sense anyway).

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/167

js/ui/altTab.js

index 35d991e20895defe3096d9bf69d893c67b7d86d1..94b80f7920745de228c4407445730825225d0cb2 100644 (file)
@@ -280,12 +280,10 @@ class AppSwitcherPopup extends SwitcherPopup.SwitcherPopup {
     }
 
     _onDestroy() {
-        super._onDestroy();
-
-        if (this._thumbnails)
-            this._destroyThumbnails();
         if (this._thumbnailTimeoutId != 0)
             GLib.source_remove(this._thumbnailTimeoutId);
+
+        super._onDestroy();
     }
 
     /**